Maybe use io.grpc.Uri for target parsing in ManagedChannelRegistry #12608
Conversation
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Ugh. That's annoying for so small a usage. But it all makes sense.
FWIW, we've been moving things to testFixtures over time, since those are never shipped to users (and users have used some of our internal test utilities). So api/src/testFixtures would have been a bit better, but it's not that big of a deal and can be changed later.
| URI uri = new URI(target); | ||
| nameResolverProvider = nameResolverRegistry.getProviderForScheme(uri.getScheme()); | ||
| String scheme = | ||
| InternalFeatureFlags.getRfc3986UrisEnabled() |
There was a problem hiding this comment.
To visibility restrict inside Google, we split the modules into two java_libraries: the main code, the Internal* accessors. The Internal* accessors can reference the main code, but that means the other direction isn't possible. We need to put the flag in a non-Internal-prefixed class, then expose that outside the package via the Internal* class.
2 participants
Will not squash.